Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Save my Changed Source Member #1603

Closed
CatMiller07 opened this issue Oct 19, 2023 · 7 comments
Closed

Can't Save my Changed Source Member #1603

CatMiller07 opened this issue Oct 19, 2023 · 7 comments
Labels
discussion For questions, or when something isn't working as expected info-needed More information is requied from the issuer stale Inactive

Comments

@CatMiller07
Copy link

Save us time! Click 'Report an Issue' from the Help and Support panel inside of VS Code after you have connected to a system.

Describe the bug
After logging-in to an IBM i, editing an RPGLE program and hitting CTRL-S to save my changes, I see an error box showing:
Failed to save 'xxxx.rpgle':Unable to write file 'member:/Library/qrpglesrc/xxxxx.rpgle'(QSYSPRT *LIBL)

Los problemas en espanol estan bien.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen:

I expected the source code to be changed -- I would be able to browse the source on the IBM i and
see my changes.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):
vsCode_iSeries_saveError

  • Extension version [e.g. 0.x.x] --
  • VS CODE Version: 1.83.1 (user setup)
    Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc
    Date: 2023-10-10T23:48:05.904Z
    Electron: 25.8.4
    ElectronBuildId: 24154031
    Chromium: 114.0.5735.289
    Node.js: 18.15.0
    V8: 11.4.183.29-electron.0
    OS: Windows 10 Pro Ver 22H2
  • IBM i OS version [e.g. 7.x] V7R3M0

Additional context
Add any other context about the problem here.

@worksofliam
Copy link
Contributor

Please share the contents of your Code for IBM i output channel after you see the error.

image

@CatMiller07
Copy link
Author

Hi Liam,
attached is the requested output.
VSCODE_Log.txt

@CatMiller07
Copy link
Author

CatMiller07 commented Oct 19, 2023 via email

@chrjorgensen
Copy link
Collaborator

chrjorgensen commented Oct 20, 2023

@CatMiller07 I see some characters in some of the comment lines in the RPG source - are you having SEU color codes in there? Code for IBM i does not like these, and you have two options:

  1. Remove the color codes from the source - my recommendation, since most modern editors have syntax coloring and don't understand the meaning of those EBCDIC hex values.
  2. Try enabling SEU color codes in the settings for the extension: image No guarantee that this will work, though...

@CatMiller07
Copy link
Author

CatMiller07 commented Oct 20, 2023 via email

@chrjorgensen
Copy link
Collaborator

I cannot pull the highlighted/colored comments because they're part of the source code history.

You don't pull the comments - you remove the hex codes from the comments and keep the text in them.

There's a SQL procedure which can do this for you here: #1375 (comment)

The only editor understanding and using these codes is SEU - and you clearly want to get away from SEU. Color codes were great in the 90's but now they are just a pain and we should get rid of them asap.

I like the concept of an affordable, RDi alternative but this one leaves much to be desired.

Code for IBM i is free and open source, and if you need more functions than is currently in the extension, you can raise an issue and suggest the functions to be included - or you can copy the source code and make the functions yourself, if so desired, and perhaps offer it back to the project in a pull request. This is what open source is all about...

@worksofliam worksofliam added the discussion For questions, or when something isn't working as expected label Oct 20, 2023
@worksofliam
Copy link
Contributor

To confirm, I just heard that RDi doesn't fully support colour codes.

@CatMiller07 If you're willing to share a hex dump of your member, I can look into this more for you.

@worksofliam worksofliam added the info-needed More information is requied from the issuer label Oct 20, 2023
@worksofliam worksofliam added the stale Inactive label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion For questions, or when something isn't working as expected info-needed More information is requied from the issuer stale Inactive
Projects
None yet
Development

No branches or pull requests

3 participants