Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully disconnect #1110

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Gracefully disconnect #1110

merged 3 commits into from
Mar 13, 2023

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Mar 3, 2023 •
edited
Loading

Changes

Implements #1175

  • Close all tabs
  • Hide all buttons
  • Remove old output log on disconnect

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam
Work to easily disconnect and reconnect
50131ee 
Signed-off-by: Liam Barry Allan <mrliamallan@live.co.uk>
@worksofliam worksofliam linked an issue Mar 3, 2023 that may be closed by this pull request
Disconnect without reload #1105
Closed
Travis CI added 2 commits March 8, 2023 18:54
Cleanup old output channel on disconnect
0677dfc 
Signed-off-by: Travis CI <liama>
Output channel now unique with name and correct disposed
93ab056 
Signed-off-by: Travis CI <liama>
@worksofliam worksofliam marked this pull request as ready for review March 9, 2023 00:03
sebjulliand
sebjulliand approved these changes Mar 11, 2023
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I gave it a shot and it works fine

@worksofliam
Copy link
Contributor Author

@chrjorgensen If you like, if you're able to review this, you can also merge in.

@worksofliam worksofliam merged commit d938a38 into master Mar 13, 2023
@sebjulliand sebjulliand mentioned this pull request Mar 16, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

@chrjorgensen chrjorgensen Awaiting requested review from chrjorgensen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disconnect without reload
2 participants
@worksofliam @sebjulliand