-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1475 fix home envvar #1621
1475 fix home envvar #1621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep &FILEDIR
for sure, but let's also keep both &WORKDIR
plus &HOME
for compatibility reasons.
When you have added &HOME
back in (you don't need to add it back to the variable list UI) then I will review again.
Hey @worksofliam was my update OK? |
@richardm90 Sorry for leaving this for so long. We had a big release and we also had to solve a big bug - I've also added I think this PR should now be used to add |
Conflicts: src/api/CompileTools.ts
@worksofliam , took me a little while as I was getting a problem when testing which must have been sorted in a recent commit as pulling down the latest has resolved my problem. I've updated the PR as suggested. |
@richardm90 I am sorry - every time I come around to look at this there are new conflicts. Any chance you can fix those and I can get another review in? |
@richardm90 , no problem, I'll get to it this week along with the comments you left on the other pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@worksofliam I've applied the latest changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
If you want to update this page for local development to include these changes, you're welcome: https://github.com/codefori/docs/blob/main/docs/pages/developing/local/actions.md
Changes
This PR relates to issue #1475.
I have modified
CompileTools.ts
so that it no longer sets theHOME
variable, which goes on to set the PASEHOME
environment variable. I have also added a new variable calledWORKDIR
, as a replacement forHOME
.In doing so the
HOME
variable is no longer available for use in actions.IMPORTANT Is there a way to advise users that their actions will need updating?
I have also added another new variable called
FILEDIR
that gives you the remote directory that the file exists. This is extremely useful when you have multipleMakefile
s in your project. You can have an action command such ascd &FILEDIR && /QOpenSys/pkgs/bin/gmake
.I have also updated the
varinfo.ts
and appropriate locale files with the action variable description changes. I used Google Translate on the French and Danish versions so if someone could check these that would be useful.Checklist
console.log
s I added