Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save password during connection via API #1630

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

worksofliam
Copy link
Contributor

Changes

Adds new parameter to the connectDirect API to store the password into the keystore. This is so the debugger doesn't prompt the user awhen using the API to connect.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam linked an issue Nov 6, 2023 that may be closed by this pull request
@william-xiang
Copy link
Contributor

@worksofliam It works inside the Merlin now. Thank you.

@worksofliam worksofliam merged commit b411a7f into master Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger asking for password when connecting with password
2 participants