Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IFS browser enhancements #1700

Merged
merged 4 commits into from
Dec 12, 2023
Merged

IFS browser enhancements #1700

merged 4 commits into from
Dec 12, 2023

Conversation

chrjorgensen
Copy link
Collaborator

Changes

This PR changes the IFS browser behavior in the following ways:

  • When copying or moving an object, only the object name will be selected in the prompt for faster entering of new object name. Previously the full path was selected, which seemed a bit cumbersome.
  • When creating a new directory or streamfile, the prompt is changed to not select the full path, but instead place the cursor after the path. This makes it faster to enter the name of the new directory or streamfile.
  • A protection mechanism for vital IBM directories has been created. Now the following directories will not have the menu options for delete, copy or move:
    • /
    • /QOpenSys
    • /QSYS.LIB
    • /QDLS
    • /QOPT
    • /QNTC
    • /QFileSvr.400
    • /bin
    • /dev
    • /home
    • /tmp
    • /usr
    • /var

The PR will make it faster working with objects in the IFS and increase the security when working in the IFS.

Checklist

  • have tested my change
  • eslint is not complaining
  • for feature PRs: PR only includes one feature enhancement.

@chrjorgensen chrjorgensen added the enhancement New feature or request label Dec 7, 2023
@worksofliam worksofliam added this to the 2.6.0 milestone Dec 11, 2023
worksofliam
worksofliam previously approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is working as expected on those protected directories. I love this UX change!

image

The highlighted text is a super nice change!!

image

@worksofliam
Copy link
Contributor

@chrjorgensen Merge whenever you feel comfy. Thanks!

sebjulliand
sebjulliand approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice UX change! 😍

@sebjulliand sebjulliand merged commit cf18c29 into codefori:master Dec 12, 2023
1 check passed
@chrjorgensen chrjorgensen deleted the feature/ifs-browser-enhancements branch December 12, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

@worksofliam worksofliam Awaiting requested review from worksofliam

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chrjorgensen @worksofliam @sebjulliand