Fix error copying empty member #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrjorgensen
added
the
bug
sebjulliand
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
Works fine. Before the PR, copying a non-empty member would show an error message.
Now copying both an empty and non-empty member works. Good job @chrjorgensen!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR will fix the change from PR #1851 - the test in the PR was not correct.
Now we check for return code first, and only if error code 1 and messages and not messages
CPF2869 (Empty member &3 in file &1 in library &2 is not copied.)andCPF2817 (Copy command ended because of error.)do we ignore the errors and accept the outcome.
Checklist