-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up library list loading when SQL is disabled #1880
Conversation
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebjulliand LGTM - same result as before the change.
But I don't see any speed difference with my 6 libraries in the library list. Have we had any reports of slow library list view?
I did not report it, but it's been bothering me lately as I kept seeing the view loading for too long on one of the LPAR I work on. |
For the record: that development LPAR has 11010 libraries 😅 And since my profile has But thanks for testing and validating, much appreciated! |
That's a lot of |
Wauw - you should do some cleanup! 😆 I tested in one of our LPARs with 1227 libraries and didn't see any difference after the change. I remember once thinking about why all libraries were included, but back then we could not send multiple commands at once, so I decided that it was better keep getting all libraries with one command / round-trip than getting one at a time and having multiple commands and round-trips. Your excellent change allowing us to run multiple commands in only one round-trip now made this change possible. Thanks! |
Thank you guys! |
Changes
When SQL is disabled, loading the library list items take a significant amount of time because it runs
DSPOBJD OBJ(QSYS/*ALL)
to load the librarys' description.This PR makes it run one
DSPOBJD
for each library which speeds up the loading of the Library List view.The other possible fix for this is to disregard
config.enableSQL
entirely and always useOBJECT_STATISTICS
.Checklist