Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance date formatting and improve test coverage #2379

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Enhance date formatting and improve test coverage #2379

merged 2 commits into from
Nov 27, 2024

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Nov 27, 2024 •
edited
Loading

Refactor date formatting to utilize the safeIsoValue function for better consistency and error handling. Add additional test cases to verify member text functionality. Will solve 'Invalid time value' error.

  • The test cases for getMemberList are passing
  • IFS Browser and Object Browser still functioning.
image

@worksofliam
Small addition to test cases to check member text
865db57 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam
Refactor date formatting to use safeIsoValue function for consistency…
c9b9692 
… and error handling

Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam worksofliam linked an issue Nov 27, 2024 that may be closed by this pull request
invalid time value #2375
Closed
@github-actions GitHub Actions
Copy link
Contributor

👋 A new build is available for this PR based on c9b9692.

sebjulliand
sebjulliand approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worksofliam worksofliam merged commit f4c59e7 into master Nov 27, 2024
1 check passed
@YvesACG
Copy link

YvesACG commented Nov 27, 2024

Looks good for me too.
I did some tests with different profiles with CCSID 1147, 297, 65535, disconnection - re connection, closing VSCode, ... .
Member list is displayed every time

@sebjulliand sebjulliand deleted the fix/support_bad_dates branch November 27, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid time value
3 participants
@worksofliam @YvesACG @sebjulliand