Use pfgrep instead of QShell grep when possible #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pfgrep][pfgrep] is a fast alternative to QShell grep. It aims to be much faster and support the full spectrum of PCRE regular expression functionality. In my testing, searching for the string `Qp0l` in `QSYSINC/H` shows: - qshell grep: ~11 seconds - pfgrep v0.2: ~8 seconds - pfgrep v0.3: ~2 seconds Quite a big improvement! Questions include: - Should VS Code offer to point you to where to download pfgrep? It's not yet in the IBM repository, but we do have our own repo, RPMs available, and it can be built from source. - With faster search, doing things like regular expressions or searching across multiple files/libraries goes from tedious to quite possible. That's out of scope for this PR, but would be quite nice to add. Same deal for regular expressions instead of fixed strings. - If you do need any features in pfgrep, let me know. I can prioritize things that VS Code needs. [pfgrep]: https://github.com/SeidenGroup/pfgrep
This is the main question. I suspect the best we can do is offer a page in our docs (under Tips) specifically for getting |
By default pfgrep includes the full record, including whitespace. Maybe this should be changed, but this is what it does now; use -t to match semantics of qsh grep. Note that this will need pfgrep v0.3.2; there was a bug in character trimming in previous versions.
We don't have skips I think, so this may be weird.
|
Might want to wait for next version, I'm working on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pfgrep is a fast alternative to QShell grep. It aims to be much faster and support the full spectrum of PCRE regular expression functionality.
In my testing, searching for the string
Qp0linQSYSINC/Hshows:Quite a big improvement!
Questions include:
Changes
Description of change here.
How to test this PR
Examples:
Checklist
console.logs I added