Merge pull request #69 from codefresh-io/CR-7602-sync-v3.2.3

Cr 7602 sync v3.2.3

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,35 +1,45 @@
 ---
 name: Reproducible bug report 
 about: Create a reproducible bug report. Not for support requests.
-labels: 'bug'
+labels: ['bug', 'triage']
 ---
-## Summary 
+<!--
+Before we start, around 2/3 of issues can be fixed by one of the following:
 
-What happened/what you expected to happen?
+* Have you double-checked your configuration? Maybe 30% of issues are wrong configuration.
+* Have you tested to see if it is fixed in the latest version? Maybe 20% of issues are fixed by this.
+* Have you tried using the PNS executor instead of Docker? Maybe 50% of artifact related issues are fixed by this.
 
-## Diagnostics
+If this is a regression, please open a regression report instead.
+-->
 
-What Kubernetes provider are you using? 
+## Summary
 
-What version of Argo Workflows are you running? 
+What happened/what you expected to happen?
 
-What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary
+What version of Argo Workflows are you running?
 
-Did this work in a previous version? I.e. is it a regression?
+## Diagnostics
+
+Either a workflow that reproduces the bug, or paste you whole workflow YAML, including status, something like:
 
 ```yaml
-Paste a workflow that reproduces the bug, including status:
-kubectl get wf -o yaml ${workflow} 
+kubectl get wf -o yaml ${workflow}
 ```
 
-```
-Paste the logs from the workflow controller:
+What Kubernetes provider are you using?
+
+What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary
+
+```bash
+# Logs from the workflow controller:
 kubectl logs -n argo deploy/workflow-controller | grep ${workflow}
-```
 
-```
-Paste the logs from your workflow's wait container:
-kubectl logs -c wait -l workflows.argoproj.io/workflow=${workflow}
+# The workflow's pods that are problematic:
+kubectl get pod -o yaml -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
+
+# Logs from in your workflow's wait container, something like:
+kubectl logs -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
 ```
 
 ---

.github/ISSUE_TEMPLATE/config.yml

@@ -10,3 +10,6 @@ contact_links:
   - name: Chat on Slack
     url: https://argoproj.github.io/community/join-slack
     about: Maybe chatting with the community can help
+  - name: 30m to talk anything Argo
+    url: https://bit.ly/book-30m-with-argo-team
+    about: Sign-up for 30m with the core Argo engineers

.github/ISSUE_TEMPLATE/regression.md

@@ -0,0 +1,41 @@
+---
+name: Regression report
+about: Create a regression report. Not for support requests.
+labels: ['bug', 'regression', 'triage']
+---
+## Summary
+
+What happened/what you expected to happen?
+
+What version is it broken in?
+
+What version was it working in?
+
+## Diagnostics
+
+Either a workflow that reproduces the bug, or paste you whole workflow YAML, including status, something like:
+
+```yaml
+kubectl get wf -o yaml ${workflow}
+```
+
+What Kubernetes provider are you using?
+
+What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary
+
+```bash
+# Logs from the workflow controller:
+kubectl logs -n argo deploy/workflow-controller | grep ${workflow}
+
+# The workflow's pods that are problematic:
+kubectl get pod -o yaml -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
+
+# Logs from in your workflow's wait container, something like:
+kubectl logs -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
+```
+
+---
+<!-- Issue Author: Don't delete this message to encourage other users to support your issue! -->
+**Message from the maintainers**:
+
+Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

.github/pull_request_template.md

@@ -1,10 +1,9 @@
-Checklist:
-
-* [ ] My organization is added to [USERS.md](https://github.com/argoproj/argo-workflows/blob/master/USERS.md).
-
 Tips:
 
+* Maybe add you organization to [USERS.md](https://github.com/argoproj/argo-workflows/blob/master/USERS.md).
 * Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
 * Sign-off your commits to pass the DCO check: `git commit --signoff`.
 * Run `make pre-commit -B` to fix codegen or lint problems. 
 * Say how how you tested your changes. If you changed the UI, attach screenshots.
+* If changes were requested, and you've made them, then dismis the review to get it looked at again.
+* You can ask for help! 

.github/workflows/changelog.yaml

@@ -7,6 +7,7 @@ on:
       - "!v0.0.0"
 jobs:
   generate_changelog:
+    if: github.repository == 'argoproj/argo-workflows'
     runs-on: ubuntu-latest
     name: Generate changelog
     steps:
@@ -22,4 +23,5 @@ jobs:
         with:
           title: 'docs: updated CHANGELOG.md'
           commit-message: 'docs: updated CHANGELOG.md'
+          branch: create-pull-request/changelog
           signoff: true

.github/workflows/ci-build.yaml

@@ -15,12 +15,12 @@ jobs:
     name: Unit Tests
     runs-on: ubuntu-20.04
     # 5m30
-    timeout-minutes: 7
+    timeout-minutes: 8
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: "1.15.7"
+          go-version: "1.16"
       - uses: actions/cache@v2
         with:
           path: /home/runner/.cache/go-build
@@ -59,6 +59,9 @@ jobs:
           - test: test-cron
             containerRuntimeExecutor: docker
             profile: minimal
+          - test: test-examples
+            containerRuntimeExecutor: emissary
+            profile: minimal
           - test: test-executor
             containerRuntimeExecutor: docker
             profile: minimal
@@ -78,7 +81,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: "1.15.7"
+          go-version: "1.16"
       - uses: actions/cache@v2
         with:
           path: /home/runner/.cache/go-build
@@ -91,10 +94,6 @@ jobs:
         with:
           path: /home/runner/go/bin
           key: go-bin-v1-${{ hashFiles('**/go.mod') }}
-      - uses: actions/cache@v2
-        with:
-          path: dist/kustomize
-          key: kustomize
       - run: mkdir -p /tmp/log/argo-e2e
       - name: Install and start K3S
         timeout-minutes: 3
@@ -136,7 +135,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: "1.15.7"
+          go-version: "1.16"
       - uses: actions/cache@v2
         with:
           path: /home/runner/.cache/go-build
@@ -176,15 +175,15 @@ jobs:
     name: Lint
     runs-on: ubuntu-20.04
     needs: [ tests, codegen ]
-    timeout-minutes: 5
+    timeout-minutes: 6
     env:
       GOPATH: /home/runner/go
     steps:
       - uses: actions/checkout@v2
       - run: cp server/static/files.go.stub server/static/files.go
       - uses: golangci/golangci-lint-action@v2
         with:
-          version: v1.36.0
+          version: v1.42.0
 
   ui:
     name: UI

.github/workflows/gh-pages.yaml

@@ -7,6 +7,7 @@ on:
 
 jobs:
   deploy:
+    if: github.repository == 'argoproj/argo-workflows'
     runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v2
@@ -17,7 +18,7 @@ jobs:
       - name: Setup Golang
         uses: actions/setup-go@v1
         with:
-          go-version: '1.15.7'
+          go-version: '1.16'
       - name: build
         run: |
           pip install mkdocs==1.0.4 mkdocs_material==4.1.1

.github/workflows/release.yaml

@@ -16,6 +16,7 @@ defaults:
 jobs:
   build-linux-amd64:
     name: Build & push linux/amd64
+    if: github.repository == 'codefresh-io/argo-workflows'
     runs-on: ubuntu-20.04
     strategy:
       matrix:
@@ -83,6 +84,7 @@ jobs:
 
   build-linux-arm64:
     name: Build & push linux/arm64
+    if: github.repository == 'codefresh-io/argo-workflows'
     runs-on: ubuntu-20.04
     strategy:
       matrix:
@@ -155,6 +157,7 @@ jobs:
 
   build-windows:
     name: Build & push windows
+    if: github.repository == 'codefresh-io/argo-workflows'
     runs-on: windows-2019
     steps:
       - uses: actions/checkout@v2
@@ -194,56 +197,11 @@ jobs:
             docker push quay.io/$image_name
           done
 
-  push-linux-amd64-images:
-    name: Push manifest with linux/amd64
-    runs-on: ubuntu-20.04
-    needs: [ build-linux-amd64 ]
-    steps:
-      - uses: actions/checkout@v2
-      ## Codefresh - remove dockerhub
-      # - name: Docker Login
-      #   uses: Azure/docker-login@v1
-      #   with:
-      #     username: ${{ secrets.DOCKERIO_USERNAME }}
-      #     password: ${{ secrets.DOCKERIO_PASSWORD }}
-
-      - name: Login to Quay
-        uses: Azure/docker-login@v1
-        with:
-          login-server: quay.io
-          username: ${{ secrets.QUAYIO_USERNAME }}
-          password: ${{ secrets.QUAYIO_PASSWORD }}
-
-      - name: Push Multiarch Image
-        env:
-          DOCKERIO_ORG: ${{ secrets.DOCKERIO_ORG }}
-        run: |
-          echo $(jq -c '. + { "experimental": "enabled" }' ${DOCKER_CONFIG}/config.json) > ${DOCKER_CONFIG}/config.json
-
-          docker_org=$DOCKERIO_ORG
-
-          tag=$(basename $GITHUB_REF)
-          if [ $tag = "master" ]; then
-            tag="latest"
-          fi
-
-          targets="workflow-controller argoexec argocli"
-          for target in $targets; do
-            image_name="${docker_org}/${target}:${tag}"
-
-            ## Codefresh - remove dockerhub
-            # docker manifest create $image_name ${image_name}-linux-amd64
-            docker manifest create quay.io/$image_name quay.io/${image_name}-linux-amd64
-
-            ## Codefresh - remove dockerhub
-            # docker manifest push $image_name
-            docker manifest push quay.io/$image_name
-          done
-
   push-images:
     name: Push manifest with all images
+    if: github.repository == 'codefresh-io/argo-workflows'
     runs-on: ubuntu-20.04
-    needs: [ build-linux-arm64, build-windows, push-linux-amd64-images ]
+    needs: [ build-linux-amd64, build-linux-arm64, build-windows ]
     steps:
       - uses: actions/checkout@v2
       ## Codefresh - remove dockerhub
@@ -291,8 +249,10 @@ jobs:
             # docker manifest push $image_name
             docker manifest push quay.io/$image_name
           done
+
   test-images-linux-amd64:
     name: Try pulling linux/amd64
+    if: github.repository == 'codefresh-io/argo-workflows'
     runs-on: ubuntu-20.04
     needs: [ push-images ]
     strategy:
@@ -332,6 +292,7 @@ jobs:
 
   test-images-windows:
     name: Try pulling windows
+    if: github.repository == 'codefresh-io/argo-workflows'
     runs-on: windows-2019
     needs: [ push-images ]
     steps:
@@ -368,6 +329,7 @@ jobs:
 
   publish-release:
     runs-on: ubuntu-20.04
+    if: github.repository == 'codefresh-io/argo-workflows'
     needs: [ push-images, test-images-linux-amd64, test-images-windows ]
     env:
       NODE_OPTIONS: --max-old-space-size=4096
@@ -385,7 +347,7 @@ jobs:
           key: ${{ runner.os }}-node-dep-v1-${{ hashFiles('**/yarn.lock') }}
       - uses: actions/setup-go@v2
         with:
-          go-version: "1.15.7"
+          go-version: "1.16"
       - uses: actions/cache@v2
         with:
           path: /home/runner/.cache/go-build

.github/workflows/sdks.yaml

@@ -0,0 +1,29 @@
+name: SDKs
+on:
+  push:
+    tags:
+      - v*
+      - 'v3.2.*'
+      - 'v3.1.*'
+    branches:
+      - dev-*
+jobs:
+  sdk:
+    if: github.repository == 'argoproj/argo-workflows'
+    runs-on: ubuntu-latest
+    name: Publish SDK
+    strategy:
+      matrix:
+        name:
+        - java
+    steps:
+      - uses: actions/checkout@v2
+      - run: make --directory sdks/${{matrix.name}} publish -B
+        env:
+          JAVA_SDK_MAVEN_PASSWORD: ${{ secrets.GITHUB_TOKEN }}
+      - uses: peter-evans/create-pull-request@v3
+        with:
+          title: 'chore: updated ${{matrix.name}} SDK'
+          commit-message: 'chore: updated ${{matrix.name}} SDK'
+          branch: create-pull-request/sdk/${{matrix.name}}
+          signoff: true