Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

describe compiler configuration on run #248

Merged
merged 1 commit into from
Dec 16, 2022
Merged

describe compiler configuration on run #248

merged 1 commit into from
Dec 16, 2022

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Nov 13, 2022

improve current info message

[INFO] Compiling 29 source files to target/test-classes

with more detailed

[INFO] Compiling 29 source files with javac [forked debug release 11] to target/test-classes

@hboutemy hboutemy requested a review from olamy November 13, 2022 17:51
@hboutemy hboutemy requested review from olamy and removed request for olamy November 27, 2022 16:47
@olamy
Copy link
Member

olamy commented Nov 28, 2022

Not sure exactly why but I would prefer something such -debug to show it as a compiler option.
I don't really have a strong option on this :)
But TBH it will add some verbosity to an already verbose console as it will generate a very long line as the destination directory is usually displayed as full path. Or you changed that to relative path to basedir?

@hboutemy
Copy link
Member Author

good idea for relative path: see #250

and for the options displayed in this PR, it's not full options, which would be too verbose, but just a few key interesting aspects like release/target bytecode

@hboutemy hboutemy force-pushed the describe branch 2 times, most recently from a086aef to 592e5c8 Compare December 15, 2022 22:57
@hboutemy hboutemy merged commit b2daea9 into master Dec 16, 2022
@hboutemy hboutemy deleted the describe branch December 16, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants