Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log all compiler output at debug level #296

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Log all compiler output at debug level #296

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28bffc8
log all compiler output at debug level
jaredstehler Jun 30, 2023
20152f3
use platform-specific EOL
jaredstehler Jul 12, 2023
c869426
Merge branch 'master' into debug-javac-output
jaredstehler Aug 28, 2024
2ef5eee
fix build for logger scope
jaredstehler Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavacCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,10 @@ protected CompilerResult compileOutOfProcess(CompilerConfiguration config, Strin
try {
returnCode = CommandLineUtils.executeCommandLine(cli, out, out);

if (getLog().isDebugEnabled()) {
getLog().debug("Compiler output:{}{}", EOL, out.getOutput());
}

messages = parseModernStream(returnCode, new BufferedReader(new StringReader(out.getOutput())));
} catch (CommandLineException | IOException e) {
throw new CompilerException("Error while executing the external compiler.", e);
Expand Down Expand Up @@ -587,7 +591,7 @@ protected CompilerResult compileInProcessWithProperClassloader(Class<?> javacCla
/**
* Helper method for compileInProcess()
*/
private static CompilerResult compileInProcess0(Class<?> javacClass, String[] args) throws CompilerException {
private CompilerResult compileInProcess0(Class<?> javacClass, String[] args) throws CompilerException {
StringWriter out = new StringWriter();

Integer ok;
Expand All @@ -599,6 +603,10 @@ private static CompilerResult compileInProcess0(Class<?> javacClass, String[] ar

ok = (Integer) compile.invoke(null, new Object[] {args, new PrintWriter(out)});

if (getLog().isDebugEnabled()) {
getLog().debug("Compiler output:{}{}", EOL, out.toString());
}

messages = parseModernStream(ok, new BufferedReader(new StringReader(out.toString())));
} catch (NoSuchMethodException | IOException | InvocationTargetException | IllegalAccessException e) {
throw new CompilerException("Error while executing the compiler.", e);
Expand Down