Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codebase #6

Merged
merged 5 commits into from
Sep 9, 2021
Merged

Update codebase #6

merged 5 commits into from
Sep 9, 2021

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Aug 10, 2021

Changes:

  • update to 2.0
  • drop plexus container default, use SISU
  • cleanup and sanitize code

@cstamas
Update codebase
f468b31 
Changes:
* update to 2.0
* drop plexus container default, use SISU
* cleanup and sanitize code
@cstamas cstamas self-assigned this Aug 10, 2021
michael-o
michael-o reviewed Aug 10, 2021
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
michael-o
michael-o reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but does not comply with the general formatting of the remaining code.

@cstamas
Copy link
Member Author

cstamas commented Sep 9, 2021

Looks fine, but does not comply with the general formatting of the remaining code.

fixed

michael-o
michael-o approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cstamas cstamas merged commit ef68799 into master Sep 9, 2021
@cstamas cstamas deleted the update-codebase branch September 9, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz approved these changes

@michael-o michael-o michael-o approved these changes

@olamy olamy Awaiting requested review from olamy

Assignees

@cstamas cstamas

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstamas @michael-o @slachiewicz