Simplify and tidy up config #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy up model. Relocation: drop all that webdav mumbo-jumbo, and for now relocation is interpreted as Path, that if relative, is resolved from the relocated configuration directory.
gnodet
reviewed
Sep 29, 2024
| writeFile(target, configuration, false); | ||
| } | ||
|
|
||
| public static void writeWithBackup(Path target, SettingsSecurity configuration) throws IOException { |
There was a problem hiding this comment.
The pattern is usually to have writeFile(Path, SettingsSecurity) and writeFile(Path, SettingsSecutiry, boolean) methods public methods, the first one calling the second one. And I don't see any reference to the first method. If not called, maybe simply keep the one with the backup.
There was a problem hiding this comment.
test UT uses the "no backup method", but will remove one extra method and apply pattern you propose
gnodet
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up model.
Relocation: drop all that mumbo-jumbo.