Forwarding #92
Closed
Forwarding #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good in general, however the underlying SPI name |
kwin
reviewed
Jan 28, 2025
| public class ForwardingDispatcher implements Dispatcher, DispatcherMeta { | ||
| public static final String NAME = "forwarding"; | ||
|
|
||
| private static final String CONF_SOURCE = "source"; |
There was a problem hiding this comment.
Isn't the source already encoded in the prefix? Why bind this dispatcher to a single source instead of leveraging all MasterSource implementations?
|
Superseded by #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarding dispatcher, that supports only decrypt (is "secure source") operation, and simply forwards all requests to some source, like for example 1Password source is.