Remove special chars from xml output #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to: apache/maven-invoker-plugin#242 |
src/test/java/org/codehaus/plexus/util/xml/Xpp3DomWriterTest.java
Outdated
Show resolved
Hide resolved
|
Looking at the code as a whole I absolutely do not understand why the framework allows to produce invalid (unescaped) XML. It simply does not make sense to me. |
|
@slawekjaranowski I have pushed a naive solution to the problem. @elharo WDYT? |
|
Next commit with removing special chars - fix build in invoker |
slawekjaranowski
changed the title
|
Can 4.x be used with Maven 3.x? |
Generally no - I will cherry pick to 3.x |
elharo
reviewed
May 19, 2024
src/test/java/org/codehaus/plexus/util/xml/pull/MXSerializerTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/util/xml/PrettyPrintXMLWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/util/xml/PrettyPrintXMLWriter.java
Outdated
Show resolved
Hide resolved
| text = escapeXml(text); | ||
|
|
||
| Matcher m = lowersText.matcher(text); | ||
| StringBuffer b = new StringBuffer(); |
There was a problem hiding this comment.
appendReplacement require StringBuffer, StringBuilder is supported from JDK 9
michael-o
approved these changes
May 20, 2024
elharo
reviewed
May 20, 2024
src/main/java/org/codehaus/plexus/util/xml/PrettyPrintXMLWriter.java
Outdated
Show resolved
Hide resolved
elharo
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.