Merge pull request #2515 from najdanovicivan/layout-renderer-fix

Layout Renderer Fix
codeigniter4 · Jan 30, 2020 · 02565d1 · 02565d1
2 parents add2f5f + e32785e
commit 02565d1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/system/View/View.php b/system/View/View.php
@@ -480,9 +480,10 @@ public function renderSection(string $sectionName)
 			return;
 		}
 
-		foreach ($this->sections[$sectionName] as $contents)
+		foreach ($this->sections[$sectionName] as $key => $contents)
 		{
 			echo $contents;
+			unset($this->sections[$sectionName][$key]);
 		}
 	}
 

diff --git a/tests/system/View/ViewTest.php b/tests/system/View/ViewTest.php
@@ -276,6 +276,18 @@ public function testRenderLayoutExtendsCorrectly()
 		$this->assertContains($expected, $view->render('extend'));
 	}
 
+	public function testRenderLayoutExtendsMultipleCalls()
+	{
+		$view = new View($this->config, $this->viewsDir, $this->loader);
+
+		$view->setVar('testString', 'Hello World');
+		$expected = "<p>Open</p>\n<h1>Hello World</h1>\n<p>Hello World</p>";
+
+		$view->render('extend');
+
+		$this->assertContains($expected, $view->render('extend'));
+	}
+
 	public function testRenderLayoutMakesDataAvailableToBoth()
 	{
 		$view = new View($this->config, $this->viewsDir, $this->loader);