Merge pull request #5700 from kenjis/fix-deprecated-getReason

refactor: replace deprecated Response::getReason() with getReasonPhrase()
codeigniter4 · Feb 16, 2022 · 048d997 · 048d997
2 parents 5dfa393 + 2fbd9b6
commit 048d997
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/Views/errors/html/error_exception.php b/app/Views/errors/html/error_exception.php
@@ -314,7 +314,7 @@
 				<table>
 					<tr>
 						<td style="width: 15em">Response Status</td>
-						<td><?= esc($response->getStatusCode() . ' - ' . $response->getReason()) ?></td>
+						<td><?= esc($response->getStatusCode() . ' - ' . $response->getReasonPhrase()) ?></td>
 					</tr>
 				</table>
 

diff --git a/system/HTTP/ResponseTrait.php b/system/HTTP/ResponseTrait.php
@@ -467,7 +467,7 @@ public function sendHeaders()
         }
 
         // HTTP Status
-        header(sprintf('HTTP/%s %s %s', $this->getProtocolVersion(), $this->getStatusCode(), $this->getReason()), true, $this->getStatusCode());
+        header(sprintf('HTTP/%s %s %s', $this->getProtocolVersion(), $this->getStatusCode(), $this->getReasonPhrase()), true, $this->getStatusCode());
 
         // Send all of our headers
         foreach (array_keys($this->getHeaders()) as $name) {

diff --git a/tests/system/HTTP/DownloadResponseTest.php b/tests/system/HTTP/DownloadResponseTest.php
@@ -277,7 +277,7 @@ public function testThrowExceptionWhenNoSetDownloadSource()
     public function testGetReason()
     {
         $response = new DownloadResponse('unit-test.php', false);
-        $this->assertSame('OK', $response->getReason());
+        $this->assertSame('OK', $response->getReasonPhrase());
     }
 
     public function testPretendOutput()