Merge pull request #8067 from kenjis/refactor-IncomingRequest-uri

refactor: make IncomingRequest::$uri protected
codeigniter4 · Oct 22, 2023 · 365e4c1 · 365e4c1
2 parents de282b9 + 9e05289
commit 365e4c1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/system/HTTP/IncomingRequest.php b/system/HTTP/IncomingRequest.php
@@ -67,11 +67,9 @@ class IncomingRequest extends Request
      * AFTER the baseURL. So, if hosted in a sub-folder this will
      * appear different than actual URI path. If you need that use getPath().
      *
-     * @deprecated Will be protected. Use getUri() instead.
-     *
      * @var URI
      */
-    public $uri;
+    protected $uri;
 
     /**
      * The detected URI path (relative to the baseURL).
@@ -125,10 +123,8 @@ class IncomingRequest extends Request
      * Configuration settings.
      *
      * @var App
-     *
-     * @deprecated Will be protected.
      */
-    public $config;
+    protected $config;
 
     /**
      * Holds the old data from a redirect.

diff --git a/user_guide_src/source/changelogs/v4.5.0.rst b/user_guide_src/source/changelogs/v4.5.0.rst
@@ -130,6 +130,8 @@ Test
 Others
 ------
 
+- **IncomingRequest::** The visibility of the deprecated properties ``$uri`` and
+  ``$config`` has been changed to protected.
 - **Config:** The deprecated ``CodeIgniter\Config\Config`` class has been removed.
 
 Enhancements