Optimize by calling preg_replace_callback() only once

codeigniter4 · Sep 25, 2021 · 4c49b17 · 4c49b17
1 parent b0f5148
commit 4c49b17
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/system/Database/Query.php b/system/Database/Query.php
@@ -406,11 +406,15 @@ public function debugToolbarDisplay(): string
 
         $sql = $this->finalQueryString;
 
-        foreach ($highlight as $term) {
-            $sql = preg_replace_callback('/\b' . preg_quote($term, '/') . '\b/', static function ($matches) {
-                return '<strong>' . str_replace(' ', '&nbsp;', $matches[0]) . '</strong>';
-            }, $sql);
-        }
+        $escapedTerms = array_map(static function ($term) {
+            return preg_quote($term, '/');
+        }, $highlight);
+
+        $search = '/\b(?:' . implode('|', $escapedTerms) . ')\b/';
+
+        $sql = preg_replace_callback($search, static function ($matches) {
+            return '<strong>' . str_replace(' ', '&nbsp;', $matches[0]) . '</strong>';
+        }, $sql);
 
         return $sql;
     }