Skip to content

Commit

Permalink
implements session->push()
Browse files Browse the repository at this point in the history
  • Loading branch information
samsonasik committed Aug 8, 2018
1 parent a8fee56 commit 6a1b643
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 0 deletions.
18 changes: 18 additions & 0 deletions system/Session/Session.php
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,24 @@ public function has(string $key)
return isset($_SESSION[$key]);
}

//--------------------------------------------------------------------

/**
* Push new value onto session value that is array.
*
* @param string $key Identifier of the session property we are interested in.
* @param array $data value to be pushed to existing session key.
*
* @return void
*/
public function push(string $key, array $data)
{
if ($this->has($key) && is_array($value = $this->get($key)))
{
$this->set($key, array_merge($value, $data));
}
}

//--------------------------------------------------------------------

/**
Expand Down
17 changes: 17 additions & 0 deletions tests/system/Session/SessionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,23 @@ public function testHasReturnsFalseOnNotFound()
$this->assertFalse($session->has('bar'));
}

public function testPushNewValueIntoArraySessionValue()
{
$session = $this->getInstance();
$session->start();

$session->set('hobbies', ['cooking' => 'baking']);
$session->push('hobbies', ['sport'=>'tennis']);

$this->assertEquals(
[
'cooking' => 'baking',
'sport' => 'tennis',
],
$session->get('hobbies')
);
}

public function testRemoveActuallyRemoves()
{
$session = $this->getInstance();
Expand Down

0 comments on commit 6a1b643

Please sign in to comment.