Micro-optimization

strtr() is faster for single-character replacements.
codeigniter4 · Oct 27, 2021 · 7880563 · 7880563
1 parent 8bbb0ea
commit 7880563
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/system/Database/BaseBuilder.php b/system/Database/BaseBuilder.php
@@ -670,7 +670,7 @@ protected function whereHaving(string $qbKey, $key, $value = null, string $type
 
                 if ($v instanceof Closure) {
                     $builder = $this->cleanClone();
-                    $v       = ' (' . str_replace("\n", ' ', $v($builder)->getCompiledSelect()) . ')';
+                    $v       = ' (' . strtr($v($builder)->getCompiledSelect(), "\n", ' ') . ')';
                 } else {
                     $bind = $this->setBind($k, $v, $escape);
                     $v    = " :{$bind}:";
@@ -842,7 +842,7 @@ protected function _whereIn(?string $key = null, $values = null, bool $not = fal
 
         if ($values instanceof Closure) {
             $builder = $this->cleanClone();
-            $ok      = str_replace("\n", ' ', $values($builder)->getCompiledSelect());
+            $ok      = strtr($values($builder)->getCompiledSelect(), "\n", ' ');
         } else {
             $whereIn = array_values($values);
             $ok      = $this->setBind($ok, $whereIn, $escape);