refactor: remove unneeded $this->params

codeigniter4 · Apr 11, 2022 · e302a3d · e302a3d
1 parent 6b9aeea
commit e302a3d
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/system/Router/AutoRouter.php b/system/Router/AutoRouter.php
@@ -39,11 +39,6 @@ class AutoRouter
      */
     protected string $method;
 
-    /**
-     * An array of params to the controller method.
-     */
-    protected array $params = [];
-
     /**
      * Whether dashes in URI's should be converted
      * to underscores when determining method names.
@@ -114,8 +109,11 @@ public function getRoute(string $uri): array
             throw PageNotFoundException::forPageNotFound();
         }
 
+        /** @var array $params An array of params to the controller method. */
+        $params = [];
+
         if (! empty($segments)) {
-            $this->params = $segments;
+            $params = $segments;
         }
 
         // Ensure routes registered via $routes->cli() are not accessible via web.
@@ -162,7 +160,7 @@ public function getRoute(string $uri): array
             );
         }
 
-        return [$this->directory, $this->controllerName(), $this->methodName(), $this->params];
+        return [$this->directory, $this->controllerName(), $this->methodName(), $params];
     }
 
     /**