refactor: move method calls to outside of the loop

codeigniter4 · Jan 24, 2022 · e77083c · e77083c
1 parent 622d611
commit e77083c
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/system/Commands/Utilities/Routes.php b/system/Commands/Utilities/Routes.php
@@ -119,17 +119,20 @@ public function run(array $params)
 
     private function getAutoRoutes(RouteCollection $collection): array
     {
-        $defaultNamespace = $collection->getDefaultNamespace();
-        $finder           = new ControllerFinder($defaultNamespace);
-        $reader           = new ControllerMethodReader($defaultNamespace);
+        $defaultNamespace  = $collection->getDefaultNamespace();
+        $defaultController = $collection->getDefaultController();
+        $defaultMethod     = $collection->getDefaultMethod();
+
+        $finder = new ControllerFinder($defaultNamespace);
+        $reader = new ControllerMethodReader($defaultNamespace);
 
         $tbody = [];
 
         foreach ($finder->find() as $class) {
             $output = $reader->read(
                 $class,
-                $collection->getDefaultController(),
-                $collection->getDefaultMethod()
+                $defaultController,
+                $defaultMethod
             );
 
             foreach ($output as $item) {