Fix debugbar loading while csp is enabled #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Potas <christoph286@googlemail.com>
Signed-off-by: Christoph Potas <christoph286@googlemail.com>
Signed-off-by: Christoph Potas <christoph286@googlemail.com>
Signed-off-by: Christoph Potas <christoph286@googlemail.com>
+ added data: to image source (csp) -> fix icons not shown Signed-off-by: Christoph Potas <christoph286@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use csp valid style and script tags for these parts of the debug bar
to fix the rest of csp problems we need to replace all inline style and scripts, so I add them to the toolbar.css. hope this is ok because it looks not optimal
another solution would be allowing inline styles but that would lower the security and also change the whole page behavior ( related to CSP )