Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to latest php-coveralls #1131

Merged
merged 1 commit into from
Aug 3, 2018
Merged

update to latest php-coveralls #1131

merged 1 commit into from
Aug 3, 2018

Conversation

samsonasik
Copy link
Member

without this, we will get error in travis under php 7.2 at coveralls command:

Submitting to https://coveralls.io/api/v1/jobs
PHP Warning:  count(): Parameter must be an array or an object that implements Countable in phar:///home/travis/build/bcit-ci/CodeIgniter4/tests/bin/coveralls.phar/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php on line 67

@samsonasik
Copy link
Member Author

coveralls is working now under php 7.2 at travis :

screen shot 2018-08-03 at 10 09 55 am

@lonnieezell
Copy link
Member

Nice catch. Thank you.

@lonnieezell lonnieezell merged commit 0f98889 into codeigniter4:develop Aug 3, 2018
@samsonasik samsonasik deleted the php-coveralls-latest branch August 3, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @lonnieezell