URI segment as page number in Pagination #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonnieezell
reviewed
Sep 11, 2018
| links with the ``makeLinks()`` adding as a 5th parameter URI segment number, which contains page number. | ||
|
|
||
| <?= $pager->makeLinks($page, $perPage, $total, 'template_name', $segment) ?> | ||
|
|
There was a problem hiding this comment.
Add additional detail showing what the uri would look like and how it would use the segment and I'm good with this PR.
There was a problem hiding this comment.
Is still anything wrong? pls lemme know.
how uri will looks like + useful notes
how uri will looks like + useful notes
- set currentPage = 1 when declared segment is not exist: i.e. http://domain.tld/user/index - first page of list. - minor fix if ``only`` option is used
|
@lonnieezell could you check if everything is ok? |
|
Your user guide writeup is awkward. Suggestion: It is also possible to use a URI segment for the page number, instead of the Please note: $segment value can not be greater than the number of URI segments plus 1. |
@jim-parry: doc fix, thx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to pass URI segment as the page number to $pager->makeLinks().
Checklist: