Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved division logic of validation rules. #1220

Merged
merged 2 commits into from
Sep 17, 2018

Conversation

ytetsuro
Copy link
Contributor

@ytetsuro ytetsuro commented Sep 14, 2018

Description

Approach for solution to the problem reported in the comment
#1203 (comment)

In order to solve this problem, we changed the division logic of verification so that it splits it with a pipe not in square brackets.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Signed-off-by: ytetsuro <phper.0o0@gmail.com>
Signed-off-by: ytetsuro <phper.0o0@gmail.com>
@lonnieezell lonnieezell merged commit 1e08dc6 into codeigniter4:develop Sep 17, 2018
@ytetsuro
Copy link
Contributor Author

Thanks merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants