Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method naming #1494

Merged
merged 3 commits into from Nov 18, 2018
Merged

Method naming #1494

merged 3 commits into from Nov 18, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2018

In the class reference of the Response Object in the user guide, statusCode() and reason() are listed. However, it should be getStatusCode() and getReason(), as statusCode() and reason() are not methods in HTTP\Response.

@jim-parry
Copy link
Contributor

I will merge this, but expect future contributions to be GPG-signed.

@jim-parry jim-parry merged commit 843201d into codeigniter4:develop Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant