Remove unused RedirectException and add some PHPDocs #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natanfelles
commented
Nov 17, 2018
| */ | ||
| public function getJSON() | ||
| { | ||
| $body = $this->body; | ||
|
|
||
| if ($this->bodyFormat !== 'json') | ||
| { | ||
| /** | ||
| * @var Format $config | ||
| */ | ||
| $config = config(Format::class); | ||
| $formatter = $config->getFormatter('application/json'); | ||
|
|
There was a problem hiding this comment.
In this file, in the line below, $formatter->format() is typed to expect an array.
Removing the type hint in the FormatterInterface allow more flexibility to work with objects, like pass an \CodeIgniter\Entity directly.
The conversion could be done inside the method, if necessary:
JSONFormatter does not needs.
There was a problem hiding this comment.
Interesting idea, and I'm ok with that. You could easily check if it's an Entity and call it's toArray() method to get the values.
natanfelles
commented
Nov 17, 2018
| */ | ||
| public function deleteCookie($name = '', string $domain = '', string $path = '/', string $prefix = '') | ||
| { | ||
| if (empty($name)) | ||
| { | ||
| return; | ||
| return $this; |
There was a problem hiding this comment.
Allow fluent method continues to work
There was a problem hiding this comment.
If the $name is empty. Should not delete all? - removing the default ''
jim-parry
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RedirectException never is thrown. Added some possible throwns.
Checklist: