Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP img fix(?) - html_helper #1538

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Conversation

nowackipawel
Copy link
Contributor

there was an issue when alt was defined in attributes array
was:
<img src="img.jpg" alt="empty or from $src array" alt="from $attributes" />

is:

<img src="img.jpg" alt="from $src if exists" />
or
<img src="img.jpg" alt="from $attributes if there is no alt in $src array" />

Todo:

  • parse $attributes if contains string instead of array to check if there is alt attribute in
    however this version is better than existing one :)

Each pull request should address a single issue, and have a meaningful title.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

---------Remove from here down in your description----------

Notes

  • Pull requests must be in English
  • If the PR solves an issue, reference it with a suitable verb and the issue number
    (e.g. fixes 12345
  • Unsolicited PRs will be considered, but there is no guarantee of acceptance
  • Pull requests should be from a feature branch in the contributor's fork of the repository
    to the develop branch of the project repository

there was an issue when alt was defined in attributes array
was:
```<img src="img.jpg" alt="empty or from $src array" alt="from $attributes" />```

is:

```<img src="img.jpg" alt="from $src if exists" />```
or
```<img src="img.jpg" alt="from $attributes if there is no alt in $src array" />```


 Todo:
- parse $attributes if contains string instead of array to check if there is alt attribute in
however this version is better than existing one :)
system/Helpers/html_helper.php Outdated Show resolved Hide resolved
system/Helpers/html_helper.php Show resolved Hide resolved
@jim-parry jim-parry changed the title img fix(?) - html_helper WIP img fix(?) - html_helper Dec 9, 2018
@nowackipawel
Copy link
Contributor Author

@lonnieezell is it still sth to change?

@lonnieezell lonnieezell merged commit bfc1569 into codeigniter4:develop Jan 3, 2019
@nowackipawel nowackipawel deleted the patch-21 branch January 4, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants