Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using protected intead of public modifier for setUp() function in tests #1556

Merged
merged 2 commits into from
Dec 3, 2018
Merged

using protected intead of public modifier for setUp() function in tests #1556

merged 2 commits into from
Dec 3, 2018

Conversation

samsonasik
Copy link
Member

The PHPUnit\Framework\TestCase::setUp() is using protected modifier.

Checklist:

  • Securely signed commits

@samsonasik samsonasik changed the title using protected intead of public modifier for setup() function in tests using protected intead of public modifier for setUp() function in tests Nov 30, 2018
@lonnieezell lonnieezell merged commit c7a9d73 into codeigniter4:develop Dec 3, 2018
@samsonasik samsonasik deleted the use-protected-setup branch December 3, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @lonnieezell