Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar IE11 fix #1931

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Toolbar IE11 fix #1931

merged 1 commit into from
Apr 11, 2019

Conversation

REJack
Copy link
Contributor

@REJack REJack commented Apr 10, 2019

Description
I fixed the Toolbar JS Code for IE Browsers.
The Internet Explorer Browsers including IE11 doesn't with window.XMLHttpRequest, these Browsers need an ActiveXObject like this new ActiveXObject('Microsoft.XMLHTTP').

Fixes #1905

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 81953eb into codeigniter4:develop Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toolbar not supporting IE11 (realXHR.responseURL)
2 participants
@REJack @lonnieezell