Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Redis legacy function #2144

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Update Redis legacy function #2144

merged 1 commit into from
Aug 14, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Aug 14, 2019

Description
From https://github.com/phpredis/phpredis:
"Note: delete is an alias for del and will be removed in future versions of phpredis."

This PR changes the call to delete() to be del() instead.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit b8a6f03 into codeigniter4:develop Aug 14, 2019
@lonnieezell
Copy link
Member

Awesome. Thanks!

@MGatner MGatner deleted the redis-fix branch August 14, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @lonnieezell