Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copy-paste extraneous text #2181

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Sep 3, 2019

Description
Just a small error of text that appears to be pasted from above.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

Looks good. Future note - if it's just a docs change you can start the commit message with [ci skip] and Travis shouldn't try to test it. Just saves them some resources.

@lonnieezell lonnieezell merged commit 81884ac into codeigniter4:develop Sep 3, 2019
@MGatner
Copy link
Member Author

MGatner commented Sep 3, 2019

OH! That's awesome! Does that work for commits on existing PRs? I've wanted to do that many times while modifying a PR with failed tests...

@MGatner MGatner deleted the path-trim branch September 3, 2019 18:28
@lonnieezell
Copy link
Member

I'm not 100% sure. Worth a try sometime :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants