Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Forge runs
dropTable()
it will check for and strip the DBPrefix from a table name if found. It does this check via(! empty($this->db->DBPrefix) ...
but sinceDBPrefix
is acquired through BaseConnection's magic__get
without a corresponding__isset()
empty()
returns false even when it isn't empty. Because of the magic getter and the initial property we can be sureDBPrefix
will always be there so it is fine to test($this->db->DBPrefix
directly. Might consider adding__isset()
to BaseConnection at some point.Checklist: