Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escape to SQLite _listTables() #2230

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Sep 17, 2019

Description
Properly escape the SQLite _listTables() filter, per #2228 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member Author

MGatner commented Sep 17, 2019

I think the coverage test is bugged, and this is a fix to the previously-merge logic error so I'm going to go for it.

@MGatner MGatner merged commit 89b6bb9 into codeigniter4:develop Sep 17, 2019
@MGatner MGatner deleted the sqlite-listtables-escaped branch September 19, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant