-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes BaseBuilder getWhere() bug #2232
Conversation
You have added returnSQL and reset parameters to the getWhere() signature. |
|
@lonnieezell @MGatner Makes sense. Are you good with this? |
It looks good to me, really nice tests. It's unfortunate how all the database & builder methods keep growing in number of parameters but I think @michalsn is right that the current implementation needs those. Maybe down the road some way of globally intercepting DB calls to return SQL could replace some of the individual versions? |
If we are adding two parameters to a method signature, shouldn't we be updating the user guide too? |
Yes, updates to user_guide_src/source/database/query_builder.rst. If @michalsn isn't around I could pass these tonight as a separate PR. |
Thanks so much @michalsn, looks great. |
Description
Fixes #2143 -
getWhere()
bug with offset.Checklist: