Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve session save handler issue #2307

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Resolve session save handler issue #2307

merged 1 commit into from
Oct 7, 2019

Conversation

jim-parry
Copy link
Contributor

Closes #2056

MGatner
MGatner approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never even seen this function before but reading it and the context I think this is a good change, if you feel good about it.

@jim-parry
Copy link
Contributor Author

Yes - it is the solution for several simialr issues, including one in CI3 with a looooong discussion thread. It's not a save handler issue, but a filesize caching problem, according to my findings.
It doesn't break anything, so will merge.

@jim-parry jim-parry merged commit 10755eb into codeigniter4:develop Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Cannot call session save handler in a recursive manner"
2 participants
@jim-parry @MGatner