Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseBuilder variable type fix #2312

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

TysiacSzescset
Copy link
Contributor

@TysiacSzescset TysiacSzescset commented Oct 8, 2019

Description
Changed $this->delete call second parameter from empty string to null.
In delete method declaration second param is type of integer or null.
IMHO it is better not to rely on type juggling where it is not necessary.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 8c057a4 into codeigniter4:develop Oct 9, 2019
@TysiacSzescset TysiacSzescset deleted the basebuilder_fix branch October 9, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants