Remove LoggerAwareTrait from Email class #2369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like this considered because the
Email
class creates aLogger
instance when it's instantiated. I'm trying to devise anEmailHandler
for theLogger
class which would require an instance of theEmail
class. I sure you can see the endless loop that is formed.It doesn't seem like removing the
LoggerAwareTrait
would affectEmail
much. It only makes one call to the resultinglogger
object. Switching that call to using the common functionlog_message
seems a good substitute for$this->logger->log...
If this PR is merged I've got a working
EmailHandler
ready to go.