Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only digits for migrations order #2387

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Nov 4, 2019

Description
See #2386 - this PR changes MigrationRunner to use only digits when ordering migrations.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

I guess this is nicer than just telling people to only use one migration type and that they should be the ones to convince the addon maintainers to change their format :)

@MGatner
Copy link
Member Author

MGatner commented Nov 5, 2019

This add-on developer may have been caught in the crossfire :ahem: 😳 I definitely plan to update all migrations to the snazzy new format but it's been a lower priority while they have been working.

@lonnieezell lonnieezell merged commit d2f0b1d into codeigniter4:develop Nov 5, 2019
@MGatner MGatner deleted the migrations-order branch November 5, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants