Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2318 - fix parse params of plugin #2411

Merged
merged 6 commits into from
Nov 26, 2019

Conversation

oleg1540
Copy link
Contributor

@oleg1540 oleg1540 commented Nov 17, 2019

Description
Fix bug #2318
Replace str_getcsv() function by regexp.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

I hesitate on this one only because that's a pretty gnarly regex pattern that takes a bit to decipher what it's doing. I wish I knew why str_getcsv() wasn't working in this condition. Will likely merge anyway, but want to dig a little deeper first.

@lonnieezell lonnieezell merged commit 6418cfe into codeigniter4:develop Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants