Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored table in CLI #2624

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Colored table in CLI #2624

merged 1 commit into from
Apr 21, 2020

Conversation

enix-app
Copy link
Contributor

@enix-app enix-app commented Feb 26, 2020

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Feb 26, 2020

Good change, looks like the static command is suppressing a newline character perhaps? Tests need to be updated for the slightly different output since it is an exact match. Alternatively you could run the result through trim() or always append a newline to $table manually.

@lonnieezell
Copy link
Member

@enix-app We like this change. Are you able to address the failing tests?

@lonnieezell lonnieezell merged commit fa559ad into codeigniter4:develop Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants