Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix. delete_cookite can't delete alreday set Cookie #2709

Merged
merged 2 commits into from
Apr 20, 2020
Merged

fix. delete_cookite can't delete alreday set Cookie #2709

merged 2 commits into from
Apr 20, 2020

Conversation

nyufeng
Copy link
Contributor

@nyufeng nyufeng commented Mar 16, 2020

Fix #2700.
Response::deleteCookie can't delete already set Cookie.
Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@nyufeng
Copy link
Contributor Author

nyufeng commented Mar 16, 2020

😢 what's wrong?

@samsonasik
Copy link
Member

@Instrye travis build failure seems unrelated

@nyufeng
Copy link
Contributor Author

nyufeng commented Apr 20, 2020

@lonnieezell plese check the PR.
fix. #2836
fix. #2700

@lonnieezell lonnieezell merged commit 0c4725d into codeigniter4:develop Apr 20, 2020
@nyufeng nyufeng deleted the patch-1 branch April 20, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delete cookie not working
3 participants
@nyufeng @samsonasik @lonnieezell