Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more test for Entity : 100% tested #2798

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

samsonasik
Copy link
Member

Added more test to CodeIgniter\Entity class, by this, CodeIgniter\Entity class will have 100% test coverage. It test the following methods conditions:

  • test toArray() skip attributes with '_' in first character.
  • test hasChanged() returns false when key not exists
  • test __get() for nullable type with has value, at castAs($value, string $type) function.

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage

@lonnieezell lonnieezell merged commit 25c58ad into codeigniter4:develop Apr 6, 2020
@samsonasik samsonasik deleted the entity-100 branch April 6, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants