Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if dataset is empty before Model update. #2808

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Check if dataset is empty before Model update. #2808

merged 1 commit into from
Apr 6, 2020

Conversation

vibbow
Copy link
Contributor

@vibbow vibbow commented Apr 6, 2020 •
edited
Loading

Description
On Model->Update, the dataset may empty after object convert to array.
So do an extra check on empty dataset before do real update.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@vibbow
Check if dataset is empty before Model update.
5921639 
Signed-off-by: vibbow <vibbow@hotmail.com>
@lonnieezell lonnieezell merged commit e838ee0 into codeigniter4:develop Apr 6, 2020
@vibbow vibbow deleted the pr_model_update_empty_check branch April 6, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vibbow @nmolinos @lonnieezell