Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue #2840 on discovery of classes by FileLocator #2844

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Fixed Issue #2840 on discovery of classes by FileLocator #2844

merged 1 commit into from
Apr 19, 2020

Conversation

paulbalandan
Copy link
Member

Fix Issue #2840 for FileLocator::findQualifiedNameFromPath() method

Description
The method returns the $className even if the class does not exist, resulting in console commands not to be discovered.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 7f16a9a into codeigniter4:develop Apr 19, 2020
@paulbalandan paulbalandan deleted the correct-filelocator-namespaced-class-finder branch April 19, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @lonnieezell