Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize dir separator of Exceptions::cleanPath and added more paths to clean #2847

Merged
merged 5 commits into from
Apr 20, 2020
Merged

Normalize dir separator of Exceptions::cleanPath and added more paths to clean #2847

merged 5 commits into from
Apr 20, 2020

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Apr 19, 2020

Description
Change the directory separator in cleaning paths to the platform-specific DIRECTORY_SEPARATOR for nicer look, especially for Windows. Also added new paths to clean.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

system/Debug/Exceptions.php Outdated Show resolved Hide resolved
system/bootstrap.php Outdated Show resolved Hide resolved
system/Test/bootstrap.php Outdated Show resolved Hide resolved
@lonnieezell lonnieezell merged commit 3e6b851 into codeigniter4:develop Apr 20, 2020
@paulbalandan paulbalandan deleted the normalize-exceptions-cleanpath branch April 20, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants