Added overwrite option to UploadedFile->move(), Issue #275 #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I''m fine with the way you did the tests. And as long as it's finding the overridden methods just fine, that works for me. The only potential thing that could have been done differently was to use vfsStream (which should be setup as a require-dev in composer.json) to mock the file activities, but that might have proved challenging in this situation. Overall - great PR. Thanks! For the future, we would like PRs to be signed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping that this resolves the issue #275.
By the way, I'm not sure with my method of overwriting the
is_uploaded_fileandmove_uploaded_filefunctions for the tests. Would like to hear a feedback about them.